Wireshark-commits: [Wireshark-commits] master-1.12 4540faf: Lua: regex test suite fails with UTF-8
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Jan 2015 03:57:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4540faf9e20cb83c113bc64cb919499dfced8721
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

4540faf by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Lua: regex test suite fails with UTF-8 locale
    
    Due to the change in change-id Ib43e16a9d98d08e5ddaff81fd3235f5b64d7b95b, the setlocale() call has been moved earlier in tshark's processing, such that Lua plugins load with the environment locale instead of C-locale. Since that matches Wireshark's behavior, it's good, but it causes the Lua regex test suite to fail. So the test suite needs to be fixed.
    
    Bug: 10824
    Change-Id: I3dcad15a9e247a1e42d2f708ccfb7272de2fe960
    Reviewed-on: https://code.wireshark.org/review/6226
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    (cherry picked from commit 3cc6aee32a54283455fa3a8832874a22b9d41114)
    Reviewed-on: https://code.wireshark.org/review/6293
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b359ca1   Lua: FieldInfo '==' check isn't really equality
    adds  4540faf   Lua: regex test suite fails with UTF-8 locale


Summary of changes:
 test/lua/gregex.lua |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)