Wireshark-commits: [Wireshark-commits] master 8541578: When deccoding base-64, the result is the le
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 2 Jan 2015 01:54:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=854157883bd1972e012c65c0418a9732ef5d9fb0
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8541578 by Guy Harris (guy@xxxxxxxxxxxx):

    When deccoding base-64, the result is the length of the *decoded* result.
    
    That way, for example, format_text() calls on the decoded result don't
    go past the end of the decoded result.
    
    Fix some more indentation while we're at it.
    
    Bug: 10823
    Change-Id: Ia7b7b1d9fb06af5df945f19a375bf5bef3277018
    Reviewed-on: https://code.wireshark.org/review/6221
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5c529c9   Add '*.nativecodeanalysis.xml' to 'clean' targets
    adds  8541578   When deccoding base-64, the result is the length of the *decoded* result.


Summary of changes:
 epan/dissectors/packet-smtp.c |   71 +++++++++++++++++++++++++----------------
 1 file changed, 43 insertions(+), 28 deletions(-)