Wireshark-commits: [Wireshark-commits] master 889c566: Eliminate proto_tree_add_text from WiMax plu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 1 Jan 2015 04:34:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=889c566b9a20d9804f654a13b5006c123b5c8301
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

889c566 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from WiMax plugin.
    
    Most of this was done with a custom perl script that picked out the field names from the XBIT macro and generated an hf_ and filter (that was humanly tweaked from there).
    
    Change-Id: I563db9f8ea216efe37322b784ab0daf25c038d9e
    Reviewed-on: https://code.wireshark.org/review/6149
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  114e773   Call setlocale() before getting version information.
    adds  889c566   Eliminate proto_tree_add_text from WiMax plugin.


Summary of changes:
 plugins/wimax/mac_hd_generic_decoder.c |   17 +-
 plugins/wimax/msg_dlmap.c              | 1484 ++++++++++++++++++++++----------
 plugins/wimax/msg_sbc.c                |   54 +-
 plugins/wimax/msg_ucd.c                |   78 +-
 plugins/wimax/msg_ulmap.c              | 1472 ++++++++++++++++++++++---------
 plugins/wimax/wimax_utils.c            |   15 +-
 6 files changed, 2228 insertions(+), 892 deletions(-)