Wireshark · Wireshark-commits: [Wireshark-commits] master 914dc6c: E.164: display country_code as decimal not hex

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=914dc6c13ebb7310bcb76252a34c942876317986
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

914dc6c by Luke Mewburn (luke@xxxxxxxxxxx):

    E.164: display country_code as decimal not hex
    
    Display and filter e164.country_code and e164.identification_code
    as decimal instead of hexadecimal, as that is more natural.
    E.g. Use 'e164.country_code == 61' instead of 'e164.country_code == 0x61'
    to match Australia (+61...)
    
    If the country_code or identification_code contain BCD digits > 9
    add an expert info warning.
    
    Required modifying the various prefix to description value_string
    arrays from hex to decimal constants, and converting the decoded BCD
    from hex to decimal before adding to the proto tree.
    
    Change-Id: Ibedfc75246fe409b7d63776083379bb028fb784b
    Reviewed-on: https://code.wireshark.org/review/6054
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  8f75a2e   And, again, no more version_info.c.
    adds  914dc6c   E.164: display country_code as decimal not hex


Summary of changes:
 epan/dissectors/packet-e164.c |  794 ++++++++++++++++++++++-------------------
 1 file changed, 428 insertions(+), 366 deletions(-)