Wireshark-commits: [Wireshark-commits] master 5b088af: Eliminate proto_tree_add_text from packet-sp
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 29 Dec 2014 13:57:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b088af31f425b375ebc2afe4a7de78c97ceac38
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5b088af by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from packet-spice.c
    
    Also do some cleanup in dissect_spice() and replace g_warning calls.
    
    Change-Id: I4dc6f6496bb5ae54157aa6f7f27f21c396da623c
    Reviewed-on: https://code.wireshark.org/review/6106
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  5f2b998   Minor doc updates, added Windows debugging info
    adds  5b088af   Eliminate proto_tree_add_text from packet-spice.c


Summary of changes:
 epan/dissectors/packet-spice.c |  528 ++++++++++++++++++++++------------------
 1 file changed, 291 insertions(+), 237 deletions(-)