Wireshark-commits: [Wireshark-commits] master 71c02b2: Create FT_FCWWN field type.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 28 Dec 2014 20:05:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71c02b20eb798569393da09fc6557c314244e3e8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

71c02b2 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Create FT_FCWWN field type.
    
    Also, convert the "string" hf_ entries that used tvb_fcwwn_to_str as a string to use proto_tree_add_item with FT_FCWWN type.
    
    Change-Id: I4ca77870499fd8239584a70874998b5d194a7167
    Reviewed-on: https://code.wireshark.org/review/6036
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8965e90   Qt Follow window: keep data representation when switching between streams
    adds  71c02b2   Create FT_FCWWN field type.


Summary of changes:
 doc/README.dissector             |   16 +++--
 epan/address.h                   |    1 +
 epan/address_to_str.c            |   49 ++++++++-------
 epan/dfilter/semcheck.c          |    5 +-
 epan/dissectors/packet-fc.c      |   10 ++-
 epan/dissectors/packet-fcdns.c   |  124 +++++++++++++++----------------------
 epan/dissectors/packet-fcels.c   |   73 +++++++++-------------
 epan/dissectors/packet-fcfcs.c   |   76 +++++++++--------------
 epan/dissectors/packet-fcip.c    |   10 ++-
 epan/dissectors/packet-fcsp.c    |   11 ++--
 epan/dissectors/packet-fcswils.c |  127 ++++++++++++++++++--------------------
 epan/dissectors/packet-fip.c     |   23 +++----
 epan/dissectors/packet-ipfc.c    |   10 ++-
 epan/dissectors/packet-scsi.c    |    6 +-
 epan/ftypes/ftype-bytes.c        |   76 ++++++++++++++++++++++-
 epan/ftypes/ftypes-int.h         |    1 +
 epan/ftypes/ftypes.h             |    2 +
 epan/proto.c                     |   40 ++++++++++++
 epan/to_str.h                    |   14 ++---
 epan/wslua/wslua_field.c         |    8 +++
 epan/wslua/wslua_proto.c         |    3 +
 epan/wslua/wslua_tree.c          |    2 +
 tools/checkAPIs.pl               |    1 -
 ui/gtk/packet_win.c              |    5 +-
 24 files changed, 382 insertions(+), 311 deletions(-)