Wireshark-commits: [Wireshark-commits] master-1.12 cc1d20f: Use getopt_long() for the first pass th
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 27 Dec 2014 02:11:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc1d20fdc9b9f9b8270e61e3164735c1cfba194a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

cc1d20f by Guy Harris (guy@xxxxxxxxxxxx):

    Use getopt_long() for the first pass through the argument list.
    
    That way:
    
    	1) we don't have to worry about the system getopt() and our
    	   getopt_long(), on platforms that have getopt() but not
    	   getopt_long() (Solaris prior to Solaris 10, HP-UX, AIX), not
    	   working well together;
    
    	2) if necessary, we can handle long options in the first pass.
    
    Switch to using getopt_long() for the *second* pass for the GTK+ version
    of Wireshark.
    
    Use the documented mechanism for resetting the argument parser for the
    glibc version of getopt_long(); use the mostly-undocumented-but-at-least-
    they-documented-optreset mechanism for the *BSD version.
    
    (We should look into doing only one pass, saving away arguments that
    can't fully be processed in the first pass for further processing after
    initializing libwireshark.)
    
    Change-Id: I891dcd33489abec5a56aae0dc9aad6758aadf97d
    Reviewed-on: https://code.wireshark.org/review/6066
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  adce5fa   WCCP: initialize address table to 0
    adds  cc1d20f   Use getopt_long() for the first pass through the argument list.


Summary of changes:
 configure.ac   |   24 ++++++++++-
 tfshark.c      |   59 +++++++++++++++++++------
 tshark.c       |   61 ++++++++++++++++++++------
 ui/gtk/main.c  |  130 +++++++++++++++++++++++++++++++++-----------------------
 ui/qt/main.cpp |  125 +++++++++++++++++++++++++++++++----------------------
 5 files changed, 268 insertions(+), 131 deletions(-)