Wireshark-commits: [Wireshark-commits] master b68fb9b: Fix some dissectors doing termio (fprintf(st
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 26 Dec 2014 20:55:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b68fb9b659b0debd7286195f9ad194be998cc3ff
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b68fb9b by Bill Meier (wmeier@xxxxxxxxxxx):

    Fix some dissectors doing termio (fprintf(stderr,..), g_warning()).
    
    - Use report_...failure() (in most cases).
    - Also: Do some misc fixes in certain disectors
      - re-arrange order of #includes
      - Fixup preferences help text
    
    Change-Id: I385f6f97257f365f53ce611df02f57f9257dc5f9
    Reviewed-on: https://code.wireshark.org/review/6039
    Petri-Dish: Bill Meier <wmeier@xxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4cf6583   Remove proto_tree_add_text from ZigBee dissectors.
    adds  b68fb9b   Fix some dissectors doing termio (fprintf(stderr,..), g_warning()).


Summary of changes:
 epan/dissectors/packet-ber.c             |    6 ++----
 epan/dissectors/packet-dcom.c            |    3 ++-
 epan/dissectors/packet-dcom.h            |    3 ++-
 epan/dissectors/packet-diameter.c        |   17 +++++++++--------
 epan/dissectors/packet-etch.c            |    2 +-
 epan/dissectors/packet-giop.c            |   13 +++++++------
 epan/dissectors/packet-smb-sidsnooping.c |    7 ++++---
 epan/dissectors/packet-ssl-utils.c       |   29 ++++++++++++++---------------
 epan/dissectors/packet-tpncp.c           |   15 ++++++++-------
 epan/dissectors/packet-uasip.c           |    7 +++++--
 10 files changed, 54 insertions(+), 48 deletions(-)