Wireshark-commits: [Wireshark-commits] master-1.12 dea8d02: wccp: use pinfo-scope memory for addres
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 26 Dec 2014 19:35:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dea8d025f19481a31e70b810458a009981c13078
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

dea8d02 by Evan Huus (eapache@xxxxxxxxx):

    wccp: use pinfo-scope memory for addresses
    
    They may be accessed during the print phase, at which point packet-scope memory
    has already been freed.
    
    Bug: 10720
    Change-Id: Ia2b160fd9de4ccaa3a4b8d9cb70fb9b32d4e08a0
    Reviewed-on: https://code.wireshark.org/review/5496
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit e843c6797db98bfceab382d5d7e76727e1014f5e)
    Conflicts:
    	epan/dissectors/packet-wccp.c
    Reviewed-on: https://code.wireshark.org/review/6057
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  84db788   Use getopt_long().
    adds  dea8d02   wccp: use pinfo-scope memory for addresses


Summary of changes:
 epan/dissectors/packet-wccp.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)