Wireshark · Wireshark-commits: [Wireshark-commits] master ceeeea0: Lua accessor for Protocol field type gets wrong data

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ceeeea089ac68366d520eaf332fed4231ce8831e
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ceeeea0 by Hadriel Kaplan (hadriel@xxxxxxxxxxxxxxxxx):

    Lua accessor for Protocol field type gets wrong data
    
    When a Lua dissector/tap accesses the value of a Field of FT_PROTOCOL ftype, the
    returned ByteArray contains the wrong data.  Also, calling such a field's
    tostring() method returns a string of "(unknown)" instead of the hex of the
    data.
    
    Bug: 10801
    Change-Id: I8a0642dc0e41af444d211bbe4106cd21207084a6
    Reviewed-on: https://code.wireshark.org/review/6003
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  2391a43   Bug 10233 - Wireshark crashes if Lua heuristic dissector returns true
    adds  ceeeea0   Lua accessor for Protocol field type gets wrong data


Summary of changes:
 epan/wslua/wslua_field.c |   23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)