Wireshark-commits: [Wireshark-commits] master 2b006ad: Have a heur_dissector_list_t be an opaque ha
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Dec 2014 04:14:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2b006ad30e38b015cfd13c33b265e2f48ddf36b2 Submitter: Guy Harris (guy@xxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: 2b006ad by Guy Harris (guy@xxxxxxxxxxxx): Have a heur_dissector_list_t be an opaque handle. This allows dissector lists to be looked up by name, so they can be shared by multiple dissectors. (This means that there's no "udplite" heuristic dissector list, but there shouldn't be one - protocols can run atop UDP or UDPLite equally well, and they share a port namespace and uint dissector table, so they should share a heuristic dissector table as well.) Change-Id: Ifb2d2c294938c06d348a159adea7a57db8d770a7 Reviewed-on: https://code.wireshark.org/review/5936 Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx> Actions performed: from 8179800 Qt: fix a crash when closing a file while capture file properties window is open adds 2b006ad Have a heur_dissector_list_t be an opaque handle. Summary of changes: asn1/atn-ulcs/packet-atn-ulcs-template.c | 4 +-- asn1/credssp/packet-credssp-template.c | 2 +- asn1/mpeg-pes/packet-mpeg-pes-template.c | 2 +- asn1/t125/packet-t125-template.c | 2 +- epan/dissectors/packet-atn-ulcs.c | 4 +-- epan/dissectors/packet-cip.c | 2 +- epan/dissectors/packet-clnp.c | 2 +- epan/dissectors/packet-corosync-totemsrp.c | 2 +- epan/dissectors/packet-credssp.c | 2 +- epan/dissectors/packet-dccp.c | 2 +- epan/dissectors/packet-dtls.c | 2 +- epan/dissectors/packet-epl.c | 4 +-- epan/dissectors/packet-eth.c | 4 +-- epan/dissectors/packet-http.c | 2 +- epan/dissectors/packet-ieee802154.c | 4 +-- epan/dissectors/packet-infiniband.c | 4 +-- epan/dissectors/packet-ip.c | 2 +- epan/dissectors/packet-iwarp-ddp-rdmap.c | 3 +-- epan/dissectors/packet-lbmc.c | 2 +- epan/dissectors/packet-media.c | 2 +- epan/dissectors/packet-mime-encap.c | 2 +- epan/dissectors/packet-mp2t.c | 2 +- epan/dissectors/packet-mpeg-pes.c | 2 +- epan/dissectors/packet-mq.c | 2 +- epan/dissectors/packet-netbios.c | 2 +- epan/dissectors/packet-ositp.c | 6 ++--- epan/dissectors/packet-pgm.c | 2 +- epan/dissectors/packet-q931.c | 2 +- epan/dissectors/packet-sccp.c | 2 +- epan/dissectors/packet-sctp.c | 2 +- epan/dissectors/packet-sercosiii.c | 2 +- epan/dissectors/packet-sip.c | 2 +- epan/dissectors/packet-smb-direct.c | 3 +-- epan/dissectors/packet-smb-pipe.c | 2 +- epan/dissectors/packet-smb2.c | 2 +- epan/dissectors/packet-soupbintcp.c | 2 +- epan/dissectors/packet-ssl.c | 2 +- epan/dissectors/packet-stun.c | 2 +- epan/dissectors/packet-sua.c | 2 +- epan/dissectors/packet-t125.c | 2 +- epan/dissectors/packet-tcp.c | 2 +- epan/dissectors/packet-tipc.c | 2 +- epan/dissectors/packet-turnchannel.c | 2 +- epan/dissectors/packet-udp.c | 3 +-- epan/dissectors/packet-usb.c | 8 +++--- epan/dissectors/packet-vines.c | 6 ++--- epan/dissectors/packet-websocket.c | 2 +- epan/dissectors/packet-wsp.c | 2 +- epan/dissectors/packet-x25.c | 2 +- epan/packet.c | 39 ++++++++++++++++----------- epan/packet.h | 12 +++++---- plugins/ethercat/packet-ethercat-datagram.c | 2 +- plugins/profinet/packet-dcerpc-pn-io.c | 2 +- plugins/profinet/packet-pn-rt.c | 2 +- 54 files changed, 93 insertions(+), 91 deletions(-)
- Prev by Date: [Wireshark-commits] master 8179800: Qt: fix a crash when closing a file while capture file properties window is open
- Next by Date: [Wireshark-commits] master 35571f8: Qt: Fix accordion frame height calculation.
- Previous by thread: [Wireshark-commits] master 8179800: Qt: fix a crash when closing a file while capture file properties window is open
- Next by thread: [Wireshark-commits] master 35571f8: Qt: Fix accordion frame height calculation.
- Index(es):