Wireshark-commits: [Wireshark-commits] master d7fd00d: MIPv6: simplify fixed point degrees conversi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Dec 2014 01:57:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d7fd00de9f35e4f54765e3e0e6025f004b678dd9
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d7fd00d by Luke Mewburn (luke@xxxxxxxxxxx):

    MIPv6: simplify fixed point degrees conversion
    
    * Simplify the conversion of degrees from 24 bit fixed point to a float.
      Avoids strict-aliasing warning by gcc 4.4.
    * Add reference to RFC 6757.
    * Correct spelling of 'convert' in degrees_convert_fixed_to_float().
    
    Change-Id: Icb680d009fdd960e8668fa3020060799d6a74c2f
    Reviewed-on: https://code.wireshark.org/review/5913
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  210aaf1   Use "" rather than <> for includes; that might fix ABI check failures.
    adds  d7fd00d   MIPv6: simplify fixed point degrees conversion


Summary of changes:
 epan/dissectors/packet-mip6.c |   45 +++++++++++++----------------------------
 1 file changed, 14 insertions(+), 31 deletions(-)