Wireshark-commits: [Wireshark-commits] master 7b2ae71: Fix filter valid/invalid test for multifield
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Dec 2014 17:59:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b2ae7123521a6000ab7f0c655ec7125c8eb688a
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7b2ae71 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Fix filter valid/invalid test for multifield custom type
    
    Check for "or" or "||" (also ignore whitespaces)
    and check both arguments of this operator to be
    fieldname (character check), then check whole filter is valid
    for dfilter compiler.
    
    Change-Id: I412b5dc1fca16fcd2b640aa74af81167300fd11e
    Reviewed-on: https://code.wireshark.org/review/5848
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Tested-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    

Actions performed:

    from  abd90c3   Fix handling of 3-component OS version numbers.
    adds  7b2ae71   Fix filter valid/invalid test for multifield custom type


Summary of changes:
 epan/column-utils.c   |   37 ++++++++++++++++++++-----------------
 ui/gtk/filter_dlg.c   |   22 ++++++++++++++++++++++
 ui/gtk/filter_dlg.h   |    3 +++
 ui/gtk/packet_list.c  |    4 ++--
 ui/gtk/prefs_column.c |    2 +-
 5 files changed, 48 insertions(+), 20 deletions(-)