Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 1416248: Don't assert out on tvb_memcpy() with a null data pointer i

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1416248dc9733b83fbf2093a6c406df2d1b145ca
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

1416248 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't assert out on tvb_memcpy() with a null data pointer if the length is 0.
    
    If the length is 0, there's nothing to copy, so it doesn't matter if
    there's no data to copy from.  This fixes problems caused by allocating
    a zero-length buffer and using that as the data for a tvbuff; the
    allocation returns null, so the data pointer is null.
    
    Bug: 9332
    Change-Id: I8037ae4b96d30e90a716852bb7e22d3980444f83
    Reviewed-on: https://code.wireshark.org/review/3761
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 66318ad5eb8235e73e66acee372df7c47cfea8bd)
    Reviewed-on: https://code.wireshark.org/review/5765
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  14be588   [Automatic manuf, services and enterprise-numbers update for 2014-12-14]
    adds  1416248   Don't assert out on tvb_memcpy() with a null data pointer if the length is 0.


Summary of changes:
 epan/tvbuff.c |   14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)