Wireshark-commits: [Wireshark-commits] master ff46ac5: rfid-pn532.c: Use FT_UINT24 to display compl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 13 Dec 2014 21:27:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ff46ac56cac3b0458e63a7a466f9f1286af50b24
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ff46ac5 by Bill Meier (wmeier@xxxxxxxxxxx):

    rfid-pn532.c: Use FT_UINT24 to display complete hex value for three 3-byte fields.
    
    Specifically: the fields are fetched as 3 bytes, but had a
     type, display of FT_UINT8, BASE_HEX so only that the LO byte was
     displayed.
    
    Change-Id: I06ea7b9527ae788be7f19278e8ba4dc2d34b2777
    Reviewed-on: https://code.wireshark.org/review/5747
    Reviewed-by: maisheri <maisheri.hitesh@xxxxxxxxx>
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  ae844d9   gsm_sms: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields
    adds  ff46ac5   rfid-pn532.c: Use FT_UINT24 to display complete hex value for three 3-byte fields.


Summary of changes:
 epan/dissectors/packet-rfid-pn532.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)