Wireshark-commits: [Wireshark-commits] master 2898f13: cip: Access FT_UINT16 hf_cip_sc_create_insta
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 12 Dec 2014 16:30:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2898f13a99d50cc8330e4bebc6b2437bc0fb84eb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2898f13 by Bill Meier (wmeier@xxxxxxxxxxx):

    cip: Access FT_UINT16 hf_cip_sc_create_instance with proper encoding-arg.
    
    Specifically: Use ENC_LITTLE_ENDIAN (not ENC_NA) to match all
                  other integral fetches in the cip dissector.
    
    Change-Id: I5d330084168493f53135dbb97674a2dba9ed7477
    Reviewed-on: https://code.wireshark.org/review/5732
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  64cb510   Change ENC_NA to ENC_BIG_ENDIAN for all fetches of integral type fields.
    adds  2898f13   cip: Access FT_UINT16 hf_cip_sc_create_instance with proper encoding-arg.


Summary of changes:
 epan/dissectors/packet-cip.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)