Wireshark-commits: [Wireshark-commits] master a971768: Refactor "color" conversation filters
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Dec 2014 09:04:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a97176853010e5e39492d8a1fea79799ef43758b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a971768 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Refactor "color" conversation filters
    
    Have dissectors register their desire to be part of "color" conversation filters and have the GUI use that registered list.  GUI actually using API will come in a separate commit.
    
    Change-Id: I5ffe922d97894fe7bf3182056b76ab5839a9461a
    Reviewed-on: https://code.wireshark.org/review/5658
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e050ad2   Eliminate some proto_tree_add_text in packet-bgp.c
    adds  a971768   Refactor "color" conversation filters


Summary of changes:
 debian/libwireshark0.symbols                       |    3 ++
 epan/CMakeLists.txt                                |    1 +
 epan/Makefile.common                               |    2 +
 ...ssector_filters.c => color_dissector_filters.c} |   14 +++---
 ...ssector_filters.h => color_dissector_filters.h} |   31 +++++++------
 epan/dissectors/packet-eth.c                       |   14 ++++++
 epan/dissectors/packet-ip.c                        |   16 +++++++
 epan/dissectors/packet-ipv6.c                      |   16 +++++++
 epan/dissectors/packet-tcp.c                       |   30 ++++++++++++
 epan/dissectors/packet-udp.c                       |   31 +++++++++++++
 epan/proto.c                                       |   27 +++++++++++
 epan/proto.h                                       |    6 +++
 plugins/profinet/packet-dcom-cba-acco.c            |   49 ++++++++++++++++++++
 13 files changed, 218 insertions(+), 22 deletions(-)
 copy epan/{dissector_filters.c => color_dissector_filters.c} (74%)
 copy epan/{dissector_filters.h => color_dissector_filters.h} (58%)