Wireshark-commits: [Wireshark-commits] master 8375a66: nfs: fix failure to parse EXCHANGE_ID argume
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Dec 2014 04:08:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8375a669f2707d2979da6578be6ddbf19ebe02c2
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8375a66 by J. Bruce Fields (bfields@xxxxxxxxxx):

    nfs: fix failure to parse EXCHANGE_ID arguments
    
    The exchange_id spo_must_enforce/spo_must_allow bitmaps are exceeding
    this arbitrary MAX_BITMAPS constant, causing EXCHANGE_ID parsing to
    fail.
    
    Even in the case of attributes we may need more than 4 words soon, even
    if we don't I'm not sure if it's actually illegal to zero-pad them out
    to something longer, and even if that is illegal I don't think it's
    really helpful of wireshark to stop parsing.
    
    Keep the constant just as a sanity check but make it really large.
    
    Ping-Bug: 10649
    Change-Id: I3dff3ebde2d7f74f8cbe60a92c853463da66ae6a
    Reviewed-on: https://code.wireshark.org/review/5144
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e4b0141   Qt: Obey main toolbar icon preferences.
    adds  8375a66   nfs: fix failure to parse EXCHANGE_ID arguments


Summary of changes:
 epan/dissectors/packet-nfs.c |   15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)