Wireshark-commits: [Wireshark-commits] master-1.12 d3fc196: Don't go past the end of the "extra dat
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 8 Dec 2014 19:51:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3fc196c6a6badc142106f9c32d88cf9104861f7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

d3fc196 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't go past the end of the "extra data".
    
    The "extra data", according to the RF5 API manual I have, is "hardware
    parameters", so change some names.
    
    Report an error if the variable parts of the configuration event record
    run past the record length.
    
    Report an error if the hardware parameters are too short.
    
    For the purportedly DS0 hardware parameters, don't assume they'll be
    long enough for the mask; they might not be.
    
    Change-Id: I438f00645a2f7a24a4b2b02afc3bb0e8fe783f40
    Reviewed-on: https://code.wireshark.org/review/5673
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2341031   Fix full name of NodeId namespace index field, was a copy&pase error
    adds  d3fc196   Don't go past the end of the "extra data".


Summary of changes:
 wiretap/k12.c |  135 ++++++++++++++++++++++++++++++++-------------------------
 1 file changed, 76 insertions(+), 59 deletions(-)