Wireshark-commits: [Wireshark-commits] master f16376e: Fix showing error dialog when calling vsimpl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 8 Dec 2014 01:15:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f16376ed7b0189afec21076619004a2dc30e65e1
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f16376e by Maarten Bezemer (maarten.bezemer@xxxxxxxxx):

    Fix showing error dialog when calling vsimple_error_message_box()
    
    SimpleDialog requires a parent, when none is provided (as there is no parent available during startup), the error message is queued and displayed after MainWindow is available.
    Calling SimpleDialog::exec() directly returns if no parent is set (hence the dialog is not shown)
    
    This resulted in silently ignoring error messages that were shown using vsimple_error_message_box(), as this function did not provide a parent (and the queue messages were not dequeued anymore as the MainWindow was already available)
    
    Change-Id: I2f4c1b4926c196ab40b035161cec530105396537
    Reviewed-on: https://code.wireshark.org/review/5519
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e172ebb   Add proto_tree_add_bitmask_with_flags.
    adds  f16376e   Fix showing error dialog when calling vsimple_error_message_box()


Summary of changes:
 ui/qt/main_window.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)