Wireshark-commits: [Wireshark-commits] master b088ca5: Squelch some "can't happen in reality" warni
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 3 Dec 2014 19:03:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b088ca5efd46d07aa36f344a7c39b9b8d038ff5d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b088ca5 by Guy Harris (guy@xxxxxxxxxxxx):

    Squelch some "can't happen in reality" warnings.
    
    (I guess newer versions of GCC/Clang know that dissect_eh_frame() is
    never called with a segment_size of 0, so the loop is traversed at least
    once.  NOTE: if it ever *is* called with a segment_size of 0, then
    that's a genuine bug and needs to be fixed.)
    
    Also, segment_size is used; no need to mark it as unused.
    
    Change-Id: I63b7a580a853b55f22494de73b4c4e6f9a387647
    Reviewed-on: https://code.wireshark.org/review/5591
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  db462ce   Try to please the buildboots by plasing th '#' at the begining of the line.
    adds  b088ca5   Squelch some "can't happen in reality" warnings.


Summary of changes:
 epan/dissectors/file-elf.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)