Wireshark-commits: [Wireshark-commits] master 08c0247: Support dissecting REAL (BER) data values
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 3 Dec 2014 09:02:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08c0247b78116dcfdba342222810697482108d3a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

08c0247 by Maarten Bezemer (maarten.bezemer@xxxxxxxxx):

    Support dissecting REAL (BER) data values
    
    Both exponent and 'integer N' values are limited:
     * max exponent is 3 octets/24-bits
     * max integer N is 8 octets/64-bit
    
    Tested with zero value/length, integers, doubles, positive and negative numbers all using the Basic Encoding Rules (BER)
    
    Change-Id: If92e1b3e209c42909b8cb76e6f50b8e6cd1da0da
    Reviewed-on: https://code.wireshark.org/review/5527
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e55fe95   Make dissect_sip_tcp() a new style dissector.
    adds  08c0247   Support dissecting REAL (BER) data values


Summary of changes:
 epan/asn1.c                  |   73 +++++++++++++++++++++++++++++++++++++++---
 epan/asn1.h                  |    2 +-
 epan/dissectors/packet-ber.c |   51 +++++++++++++++++++++--------
 epan/dissectors/packet-ber.h |    2 +-
 4 files changed, 109 insertions(+), 19 deletions(-)