Wireshark-commits: [Wireshark-commits] master 6d207fe: Remove private_data member from packet_info
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 1 Dec 2014 14:05:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6d207fe5f47f20f7c83d5c5da3e4ee0b0bca7b9b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6d207fe by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove private_data member from packet_info structure.
    
    Dissectors should pass data directly to their subdissectors through the data parameter (of new-style dissectors). This avoids unintentional "trampling" from other dissectors trying to "share" private_data member.
    
    Change-Id: I2efef5c8dfeef64588ba3ac6e695b469238c6468
    Reviewed-on: https://code.wireshark.org/review/5487
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e77507b   Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.
    adds  6d207fe   Remove private_data member from packet_info structure.


Summary of changes:
 epan/dissectors/packet-dcerpc.c         |    2 --
 epan/packet_info.h                      |    1 -
 epan/wslua/wslua_pinfo.c                |    4 ----
 plugins/profinet/packet-dcom-cba-acco.c |    1 -
 test/lua/pinfo.lua                      |    2 --
 5 files changed, 10 deletions(-)