Wireshark-commits: [Wireshark-commits] master cd14ff3: qt: use qstring_strdup
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 1 Dec 2014 01:13:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cd14ff3288232273433fec1363d5adab38afdb2c
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cd14ff3 by Peter Wu (peter@xxxxxxxxxxxxx):

    qt: use qstring_strdup
    
    Replaces the more verbose `g_strdup(foo.toUtf8().constData())` by
    `qstring_strdup(foo)`. While at it, plug a minor memleak in
    MainWindow dialogs.
    
    Change-Id: I32b53f972b4e3998ac9beabd98647a381b7b42e3
    Reviewed-on: https://code.wireshark.org/review/5531
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  0cf2f74   Squelch another compiler warning.
    adds  cd14ff3   qt: use qstring_strdup


Summary of changes:
 ui/qt/column_preferences_frame.cpp      |    5 +++--
 ui/qt/font_color_preferences_frame.cpp  |    4 +++-
 ui/qt/main_window.cpp                   |    6 ++++--
 ui/qt/main_window_preferences_frame.cpp |    4 ++--
 ui/qt/profile_dialog.cpp                |    4 +++-
 ui/qt/remote_capture_dialog.cpp         |   13 +++++++------
 ui/qt/wireshark_application.cpp         |    2 +-
 7 files changed, 23 insertions(+), 15 deletions(-)