Wireshark · Wireshark-commits: [Wireshark-commits] master 81ab601: Clean up routine names, don't pass capture_file into libwireshar

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=81ab6012fe1ae14b9d7719035b8156368fa48c7e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

81ab601 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up routine names, don't pass capture_file into libwireshark.
    
    Give all routines in epan/print.c that write a particular format a name
    beginning with write_{formatname}.
    
    If routines write columns, rather than the raw protocol tree, don't give
    it a name containing proto_tree.
    
    Get rid of empty preamble/finale routines.
    
    For CSV, the preamble routine writes out column titles, so call it
    write_csv_column_titles().
    
    For C arrays, the body routine writes out raw hex data, so call it
    write_carrays_hex_data().
    
    capture_file isn't a structure defined by libwireshark, so don't make it
    an argument passed into libwireshark.
    
    Change-Id: I5a7e04de9382cf51a59d9d9802f815b8b3558332
    Reviewed-on: https://code.wireshark.org/review/5536
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  05516b0   Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.
    adds  81ab601   Clean up routine names, don't pass capture_file into libwireshark.


Summary of changes:
 epan/print.c |   54 ++++++++++++++++++------------------------------------
 epan/print.h |   17 +++++++----------
 file.c       |   36 +++++++++++-------------------------
 tshark.c     |   14 +++++++-------
 4 files changed, 43 insertions(+), 78 deletions(-)