Wireshark-commits: [Wireshark-commits] master a600ef6: Have media dissector take its "media type pa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 25 Nov 2014 07:27:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a600ef6d5993ab8cab79e11e3e6a1218260e44c2
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a600ef6 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Have media dissector take its "media type parameter" from dissector data parameter instead of pinfo->private_data.
    
    Change-Id: I0a0cb0b4838bc4e55a759fb6031355892c220c8e
    Reviewed-on: https://code.wireshark.org/review/5461
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  518bb10   Remove use of pinfo->private_data since it's not used anywhere.
    adds  a600ef6   Have media dissector take its "media type parameter" from dissector data parameter instead of pinfo->private_data.


Summary of changes:
 epan/dissectors/packet-http.c      |    7 +++++--
 epan/dissectors/packet-jxta.c      |    4 +++-
 epan/dissectors/packet-media.c     |    4 ++--
 epan/dissectors/packet-multipart.c |    2 +-
 epan/dissectors/packet-spdy.c      |    4 +++-
 epan/dissectors/packet-wsp.c       |   20 ++++----------------
 6 files changed, 18 insertions(+), 23 deletions(-)