Wireshark-commits: [Wireshark-commits] master e899c3e: Eliminate proto_tree_add_text from some diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 25 Nov 2014 02:51:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e899c3e262594813fa765e44ad143d7f14d6d415
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e899c3e by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from some dissectors.
    
    Change-Id: Iadd80aab291e5de714891a9f3c79edeca19e9b93
    Reviewed-on: https://code.wireshark.org/review/5458
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  4f8a6ec   TCP: fix wrongly set base_seq when ISN is 0 and tcp_relative_seq is enabled
    adds  e899c3e   Eliminate proto_tree_add_text from some dissectors.


Summary of changes:
 epan/dissectors/packet-dcerpc-epm.c     |   11 +-
 epan/dissectors/packet-dcerpc-nt.c      |    7 +-
 epan/dissectors/packet-dhcpv6.c         |   56 ++++---
 epan/dissectors/packet-trmac.c          |   50 +++---
 epan/dissectors/packet-umts_mac.c       |  124 ++++++++-------
 epan/dissectors/packet-usb-video.c      |   60 +++++--
 epan/dissectors/packet-vcdu.c           |   47 ++++--
 epan/dissectors/packet-windows-common.c |  262 +++++++++++++++----------------
 epan/dissectors/packet-x29.c            |   74 +++++----
 epan/dissectors/packet-xmpp-utils.c     |    2 +-
 10 files changed, 406 insertions(+), 287 deletions(-)