Wireshark-commits: [Wireshark-commits] master-1.12 802e300: SMTP: escape ASCII strings printed to C
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Nov 2014 16:47:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=802e300f7d6840cc903701202f98f8cf1b2b3cec
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

802e300 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    SMTP: escape ASCII strings printed to COL_INFO
    
    This is already done automatically for the hf entries thanks to hfinfo_format_text() function
    
    Bug: 10536
    Change-Id: I9ee56b795234a94f0e59c82a96e3e6cedf71c4e6
    Reviewed-on: https://code.wireshark.org/review/5459
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 78849d0e6b0dde760c8bea40ce99e7a05711f3bf)
    Conflicts:
    	epan/dissectors/packet-smtp.c
    Reviewed-on: https://code.wireshark.org/review/5469
    

Actions performed:

    from  0187a2c   Presumably the intent is to dump *non*-dummy entries.
    adds  802e300   SMTP: escape ASCII strings printed to COL_INFO


Summary of changes:
 epan/dissectors/packet-smtp.c |   50 ++++++++++++++++++++++++-----------------
 1 file changed, 30 insertions(+), 20 deletions(-)