Wireshark-commits: [Wireshark-commits] master 6dbb97d: SSL: Implement Extended Master Secret
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Nov 2014 09:22:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6dbb97da103731d0abbd4fdeeef16d7af4059fa3
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6dbb97d by Dave Tapuska (dtapuska@xxxxxxxxxx):

    SSL: Implement Extended Master Secret
    
    Store all handshake mesages in a buffer so that we can hash them
    correctly when generating the master secret.
    
    This change does not work correctly for DTLS retransmitted packets; that
    are in the handshake as they will be hashed twice; which is bad. Looking
    for ideas to implement this.
    
    Bug: 10686
    Change-Id: Ied01d4cc37b4270f325070a8d1630d3123577a0d
    Reviewed-on: https://code.wireshark.org/review/5168
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  eb93f3b   Don't do unsafe pointer casting
    adds  6dbb97d   SSL: Implement Extended Master Secret


Summary of changes:
 epan/dissectors/packet-dtls.c      |    3 +
 epan/dissectors/packet-ssl-utils.c |  200 ++++++++++++++++++++++++++++--------
 epan/dissectors/packet-ssl-utils.h |    9 ++
 epan/dissectors/packet-ssl.c       |    2 +
 4 files changed, 169 insertions(+), 45 deletions(-)