Wireshark-commits: [Wireshark-commits] master 534b596: Cleanup packet-sccp.c in preparation of tryi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Nov 2014 13:52:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=534b5967c0cbedf1cf3fb50278d43f981d8b64ab
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

534b596 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Cleanup packet-sccp.c in preparation of trying to remove sccp_info member of packet_info.
    
    Convert a handful of global variables into function parameters that get passed through the dissector, so we shouldn't be dependent on pinfo->sccp_info anymore. Removal of pinfo->sccp_info will be done in a separate patch (when the dissectors that use it can be updated).
    
    packet-sua.c may need similar treatment.
    
    Change-Id: If0001638d666afc07e04b02aa32ef31d6223a5de
    Reviewed-on: https://code.wireshark.org/review/5343
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  e2b597a   Fix problem where the profile bar moves further left every time Wireshark is run.
    adds  534b596   Cleanup packet-sccp.c in preparation of trying to remove sccp_info member of packet_info.


Summary of changes:
 epan/dissectors/packet-sccp.c |  443 +++++++++++++++++++----------------------
 epan/dissectors/packet-sccp.h |   14 +-
 epan/dissectors/packet-sua.c  |   18 +-
 3 files changed, 234 insertions(+), 241 deletions(-)