Wireshark-commits: [Wireshark-commits] master b19b12a: Get rid of write_headers global variable.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Nov 2014 08:07:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b19b12a85daa9ec91537c733d05550f5dfafa0eb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b19b12a by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of write_headers global variable.
    
    Have write_psml_preamble() and write_csv_preamble() take a capture_file *
    as an argument, so they can print the column titles themselves, rather
    than having to defer it to the routine that prints packet data.
    
    Change-Id: Ifd1b7a13062be8ad46846315976922a752778153
    Reviewed-on: https://code.wireshark.org/review/5438
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6e1214c   Fix comments.
    adds  b19b12a   Get rid of write_headers global variable.


Summary of changes:
 epan/print.c |   55 ++++++++++++++++++++++---------------------------------
 epan/print.h |    4 ++--
 file.c       |    4 ++--
 tshark.c     |    2 +-
 4 files changed, 27 insertions(+), 38 deletions(-)