Wireshark-commits: [Wireshark-commits] master e77261f: Eliminate proto_tree_add_text from some diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Nov 2014 16:09:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e77261f6593b8c25635fc32d78f0f0c3c57bb902
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e77261f by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from some dissectors.
    
    Change-Id: Ib160211198ca02f7eacf29d04568628c11f208a5
    Reviewed-on: https://code.wireshark.org/review/5407
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  9611e75   Replace tvb_length...() calls.
    adds  e77261f   Eliminate proto_tree_add_text from some dissectors.


Summary of changes:
 epan/dissectors/packet-scsi-mmc.c |  108 ++++++++++----------
 epan/dissectors/packet-scsi-ssc.c |  204 ++++++++++++++++++++++---------------
 epan/dissectors/packet-scsi.c     |   44 +++++---
 epan/dissectors/packet-sdp.c      |   38 +++++--
 epan/dissectors/packet-ses.c      |  105 ++++++++-----------
 epan/dissectors/packet-smb2.c     |   77 +++++++++-----
 epan/dissectors/packet-tacacs.c   |   52 +++++++---
 epan/dissectors/packet-tcp.c      |   71 ++++++-------
 epan/dissectors/packet-zep.c      |   14 ++-
 9 files changed, 420 insertions(+), 293 deletions(-)