Wireshark-commits: [Wireshark-commits] lts-1.8.2 63b971c: sigcomp-udvm: fix invalid access
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 18 Nov 2014 04:52:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63b971cd752ac9cdb48d297a48e86851ef7e4ac1
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

63b971c by Evan Huus (eapache@xxxxxxxxx):

    sigcomp-udvm: fix invalid access
    
    Way back in 2006, svn r20041 (now gd408f2f6fc) worked around a problem by
    limiting the amount of buffer dealt with in the udvm_state_access call (changing
    it from state_minimum_access_length_buff[n] to STATE_MIN_ACCESS_LEN).
    
    The very next line however, tries to read the same amount of buffer to display
    to the user - since it seems nobody ever applied a proper fix for the original
    case, just apply the same workaround to the second call.
    
    Conflicts:
    	epan/sigcomp-udvm.c
    
    Bug: 10662
    Change-Id: I32c81ee2a8eb7b30ff7ab1fbbb6ea5f206385d4b
    Reviewed-on: https://code.wireshark.org/review/5125
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/5331
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/5355
    

Actions performed:

    from  b75179a   ncp2222: don't overflow buffer constructing string
    adds  63b971c   sigcomp-udvm: fix invalid access


Summary of changes:
 epan/sigcomp-udvm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)