Wireshark-commits: [Wireshark-commits] master a07f081: voip_calls: Get rid of global variables.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 17 Nov 2014 21:56:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a07f0817d7db615d035892e496b93c1debe33ca4
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a07f081 by Gerald Combs (gerald@xxxxxxxx):

    voip_calls: Get rid of global variables.
    
    Move the members of voip_rtp_tapinfo_t to voip_calls_tapinfo_t. Move a
    bunch of formerly static variables there as well. Note that we might
    want to make them private again at some point. Remove launch_count. It
    appeared to be unused.
    
    Wrap the individual registration routines in voip_calls_init_all_taps.
    Wrap the removal routines in voip_calls_remove_all_tap_listeners.
    
    Move voip_calls_get_info() to voip_calls_dlg.c. Make it static.
    
    Change-Id: I58f9d91f55cfb5e4b0c048a5a1d5d4b947f4641b
    Reviewed-on: https://code.wireshark.org/review/5372
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  5c7c701   802.11: Enhance Supported Operating Classes
    adds  a07f081   voip_calls: Get rid of global variables.


Summary of changes:
 ui/gtk/rtp_analysis.c   |    1 -
 ui/gtk/voip_calls.c     |  479 +++++++++++++++++++++++++----------------------
 ui/gtk/voip_calls.h     |  102 ++++------
 ui/gtk/voip_calls_dlg.c |  138 +++++++-------
 4 files changed, 366 insertions(+), 354 deletions(-)