Wireshark-commits: [Wireshark-commits] master d1696a6: "Bubble up" the use of pinfo->circuit_id and
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Nov 2014 13:46:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d1696a6569033e1c8553aeecc940cfb7f64ebf64
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d1696a6 by Michael Mann (mmann78@xxxxxxxxxxxx):

    "Bubble up" the use of pinfo->circuit_id and pinfo->ctype to make it more obvious where in used in hopes that it can be eliminated through passing dissector data (or methods other than using packet_info)
    
    Change-Id: Ib0e7efc123a3f9c06f58b5579c3c25b18818205c
    Reviewed-on: https://code.wireshark.org/review/5326
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  f92ed4d   Remove ipproto member of packet_info.
    adds  d1696a6   "Bubble up" the use of pinfo->circuit_id and pinfo->ctype to make it more obvious where in used in hopes that it can be eliminated through passing dissector data (or methods other than using packet_info)


Summary of changes:
 epan/dissectors/packet-h223.c |    2 +-
 epan/dissectors/packet-isdn.c |    8 ++++----
 epan/dissectors/packet-iuup.c |   24 ++++++++++++------------
 epan/dissectors/packet-wcp.c  |   26 +++++++++++++-------------
 4 files changed, 30 insertions(+), 30 deletions(-)