Wireshark-commits: [Wireshark-commits] master-1.12 05cb044: DNS: NAPTR RR Replacement Length is inc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Nov 2014 11:06:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=05cb0448dfed0343e86820cdd65df9e30d4a75ff
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

05cb044 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    DNS: NAPTR RR Replacement Length is incorrect
    
    It seems the Replacement Length field calculated by Wireshark (which Wireshark calls "rReplacement Length"), is the length of the first label of the DNS name in the Replacement, instead of the entire DNS name length.
    
    Issue found by Boaz
    
    Bug:10700
    Change-Id: I8b726f3a3bf316d688a40c3ade100d255ca3be42
    Reviewed-on: https://code.wireshark.org/review/5300
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 3b8ed366ddd149f2cc1428a713235c18afc192e7)
    Reviewed-on: https://code.wireshark.org/review/5329
    

Actions performed:

    from  f320526   NAS EPS: fix dissection of APN AMBR IE when first byte is set to 0xFE
    adds  05cb044   DNS: NAPTR RR Replacement Length is incorrect


Summary of changes:
 epan/dissectors/packet-dns.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)