Wireshark · Wireshark-commits: [Wireshark-commits] master 1e2a3dc: VoIP calls: Clean up tap registration and removal.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1e2a3dcb94a7a0feba684d0b824087c0f61a06d8
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1e2a3dc by Gerald Combs (gerald@xxxxxxxxxxxxx):

    VoIP calls: Clean up tap registration and removal.
    
    Start moving away from a global voip_calls_tapinfo_t. Pass the
    voip_calls_tapinfo_t struct address to each registration and removal
    routine.
    
    All of the tap registration and removal routines are called at the same
    time. Replace the individual registration tracking booleans with a
    central one.
    
    Calling exit() from the GUI is rude. Don't do that.
    
    Change-Id: I9535002e2905a45a8cfc9643590b5d2d360ffc24
    Reviewed-on: https://code.wireshark.org/review/5318
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  62fd2ac   Eliminate proto_tree_add_text from some plugin dissector files.
    adds  1e2a3dc   VoIP calls: Clean up tap registration and removal.


Summary of changes:
 ui/gtk/voip_calls.c     |  860 ++++++++++++++++++-----------------------------
 ui/gtk/voip_calls.h     |   72 ++--
 ui/gtk/voip_calls_dlg.c |   98 +++---
 3 files changed, 421 insertions(+), 609 deletions(-)