Wireshark-commits: [Wireshark-commits] master ba3bc1e: VoIP calls tap ID cleanup.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Nov 2014 00:31:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba3bc1e72686ef386945dda72b0a85b63d9e1af8
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ba3bc1e by Gerald Combs (gerald@xxxxxxxxxxxxx):

    VoIP calls tap ID cleanup.
    
    Remove all of the public dummy members from voip_calls_tapinfo_t. Use
    pointer arithmetic to generate private, unique IDs instead.
    
    We weren't removing the SUA listener. Do so. Use the correct M3UA ID.
    
    Change-Id: I8e8cdb6addbc4868aebc004be20a2f57b4acf75b
    Reviewed-on: https://code.wireshark.org/review/5315
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  225c86f   Do the "-z help" processing separately, and do it for Wireshark as well.
    adds  ba3bc1e   VoIP calls tap ID cleanup.


Summary of changes:
 ui/gtk/voip_calls.c |  115 +++++++++++++++++++++++++++++++--------------------
 ui/gtk/voip_calls.h |   25 -----------
 2 files changed, 70 insertions(+), 70 deletions(-)