Wireshark-commits: [Wireshark-commits] master a55d18e: hiqnet: Simplify code somewhat; Adjust the "
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Nov 2014 15:59:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a55d18ed611e5f4ff15c37d132ec0865c67041dd
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a55d18e by Bill Meier (wmeier@xxxxxxxxxxx):

    hiqnet: Simplify code somewhat; Adjust the "names" and display of certain fields.
    
    Specifically: Use proto_tree_add_bitmask() to show the "flags" and
                  "categories" bitfields (instead of building the fields
                  display "by hand").
                  The bitfield display changed as follows:
                  - A bitfield with all bits=0 will have a detailed
                    dissection tree; (for both 'flags' & 'categories');
                  - The 'categories' individual bitfields are now
                    displayed as FT_BOOLEAN (not FT_UINT32).
    
    Change-Id: Icd35698aae492b81b340d08030e6a1563f1640ae
    Reviewed-on: https://code.wireshark.org/review/5266
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  9a1df71   [S1AP) Wrong tree used s1ap.cnf:547:14: error: variable 'subtree' set but not used
    adds  a55d18e   hiqnet: Simplify code somewhat; Adjust the "names" and display of certain fields.


Summary of changes:
 epan/dissectors/packet-hiqnet.c |  259 ++++++++++++---------------------------
 1 file changed, 75 insertions(+), 184 deletions(-)