Wireshark · Wireshark-commits: [Wireshark-commits] master ea16705: Improved deregistering fields.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea167053ffc553b3a5f4ce6cbe0b78ecc8cd0dbe
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ea16705 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Improved deregistering fields.
    
    This improvement avoids use of deallocated memory (crash) if using a
    deregistered field in display filter, color filter, custom column and
    other cases when the field is used as "interesting field".
    
    This functionality is currently used in http, imf and ldap preferences.
    
    Also removed unused proto_registrar_n() as this does not work correctly
    after deregistering fields.
    
    Change-Id: I043e3bf7a98bd773c9801e712a012d1eab8a7f94
    Reviewed-on: https://code.wireshark.org/review/5161
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  d58567b   Fixed memory leakage in col_cleanup.
    adds  ea16705   Improved deregistering fields.


Summary of changes:
 asn1/ldap/packet-ldap-template.c |    6 +---
 debian/libwireshark0.symbols     |    3 +-
 epan/dissectors/packet-http.c    |    6 +---
 epan/dissectors/packet-imf.c     |    6 +---
 epan/dissectors/packet-ldap.c    |   14 +++-----
 epan/proto.c                     |   70 ++++++++++++++++++++++++++++++++++----
 epan/proto.h                     |   15 +++++---
 ui/gtk/main.c                    |   33 ++++++++++++++++++
 ui/gtk/main.h                    |    3 ++
 ui/gtk/uat_gui.c                 |    2 +-
 ui/qt/main_window.cpp            |    2 ++
 ui/qt/main_window.h              |    1 +
 ui/qt/main_window_slots.cpp      |   30 ++++++++++++++++
 ui/qt/uat_dialog.cpp             |    2 +-
 ui/qt/wireshark_application.cpp  |    3 ++
 ui/qt/wireshark_application.h    |    4 ++-
 16 files changed, 161 insertions(+), 39 deletions(-)