Wireshark-commits: [Wireshark-commits] master-1.12 e4224aa: DNS: WKS RR Protocol field is read as 4
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 8 Nov 2014 02:08:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4224aab2fc1677adc09c0dd6d8f151c1d823c77
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

e4224aa by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    DNS: WKS RR Protocol field is read as 4 bytes instead of 1
    
    In the attached pcap file, there's a single DNS packet with WKS RR in the Prerequisites section.
    The Protocol field of this RR is read as if it is 4 bytes long instead of 1, which actually reads part of the bytes of the following RR.
    
    Found by boaz
    
    Bug:10675
    Change-Id: Icf12c7f3864b629a242598373c06eee4de0ca098
    Reviewed-on: https://code.wireshark.org/review/5170
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit aec5ffb535be189a0861531aeceb7be557e47336)
    Reviewed-on: https://code.wireshark.org/review/5173
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d12ab6a   tn5220: prevent another potential endless loop exit the loop if dissect_unknown_data() returns 0
    adds  e4224aa   DNS: WKS RR Protocol field is read as 4 bytes instead of 1


Summary of changes:
 epan/dissectors/packet-dns.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)