Wireshark-commits: [Wireshark-commits] master 0b9c5cd: Improve error message by including the (expe
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 6 Nov 2014 17:02:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b9c5cd136c33e369fbd4e497cf2e370987cbded
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0b9c5cd by Maarten Bezemer (maarten.bezemer@xxxxxxxxx):

    Improve error message by including the (expected) class information
    
    The code checks whether the tag AND class are matching with their expected values, but only the tag information is shown in the error message.
    When the class is not matching, the error message shows the given and expected tags which are the same, confusing the user what is wrong with it.
    
    Furthermore, the messages for SEQUENCE and SEQUENCE OF are made the same/similar.
    
    Change-Id: I6c1d0968c903105ec7f6e0648d589a4263a8ca18
    Reviewed-on: https://code.wireshark.org/review/5162
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  6e81b2d   BER: Fix offset and length of EOC in Sequence loop
    adds  0b9c5cd   Improve error message by including the (expected) class information


Summary of changes:
 epan/dissectors/packet-ber.c |   38 ++++++++++++++++++++++++++------------
 1 file changed, 26 insertions(+), 12 deletions(-)