Wireshark-commits: [Wireshark-commits] master bfc5483: rpc: take a file-scope copy of some RPC proc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 5 Nov 2014 02:32:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bfc5483174d564eb20dc2576bf3a124a93075557
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bfc5483 by Evan Huus (eapache@xxxxxxxxx):

    rpc: take a file-scope copy of some RPC procedures
    
    The original may be freed out from underneath us if a duplicate is registered.
    Thanks to Bruce Fields for pointing out one case of this I'd missed.
    
    Also replace a bunch of manual "foo.field = 0" with just wmem_new0() instead.
    
    Bug: 10636
    Change-Id: I342bd732f062b0a191cbbf5ae417356385d2fd53
    Reviewed-on: https://code.wireshark.org/review/5046
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  cd93af0   Oops, we also need to worry about pcap_get_tstamp_precision().
    adds  bfc5483   rpc: take a file-scope copy of some RPC procedures


Summary of changes:
 epan/dissectors/packet-rpc.c |   14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)