Wireshark-commits: [Wireshark-commits] master ba008bf: Eliminate proto_tree_add_text from several d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 2 Nov 2014 15:42:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba008bf746843b11b98a18b957637431249d5132
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ba008bf by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from several dissectors.
    
    Change-Id: I6d3125f15d268edd47ef74dd655eb86cb25ee52d
    Reviewed-on: https://code.wireshark.org/review/5047
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  f19c70c   DNS: fix Coverity CID 281285 and CID 1238867
    adds  ba008bf   Eliminate proto_tree_add_text from several dissectors.


Summary of changes:
 epan/dissectors/packet-aim-messaging.c |    9 +-
 epan/dissectors/packet-ber.c           |   64 +++++---
 epan/dissectors/packet-bssap.c         |  158 +++++++++---------
 epan/dissectors/packet-dcom-sysact.c   |   29 ++--
 epan/dissectors/packet-dcp-etsi.c      |   31 ++--
 epan/dissectors/packet-dpnss.c         |  116 +++++++------
 epan/dissectors/packet-dtn.c           |   72 ++++----
 epan/dissectors/packet-gsm_bssmap_le.c |   47 ++++--
 epan/dissectors/packet-gvcp.c          |   44 +++--
 epan/dissectors/packet-icp.c           |   89 ++++++----
 epan/dissectors/packet-ipp.c           |  153 ++++++++---------
 epan/dissectors/packet-ipsec.c         |   47 ++++--
 epan/dissectors/packet-isakmp.c        |   76 +++++----
 epan/dissectors/packet-ldp.c           |   31 +++-
 epan/dissectors/packet-linx.c          |  281 +++++++++++++++++---------------
 15 files changed, 698 insertions(+), 549 deletions(-)