Wireshark-commits: [Wireshark-commits] master-1.10 74eace1: Announce messages should only have a TL
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Nov 2014 23:04:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74eace132700922c854d468fdcb910007d600d1c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

74eace1 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Announce messages should only have a TLV if the message length is > 64.
    
    Also, cleaned up a unnecessary global variable.
    
    Bug: 10611
    
    Reviewed-on: https://code.wireshark.org/review/5029
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    
    Conflicts:
     epan/dissectors/packet-ptp.c
    
    Change-Id: Ifb9bcde70405d591c21bd4e10195e1b192cba98b
    Reviewed-on: https://code.wireshark.org/review/5062
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  89237e3   print: do not try to add an empty hex stream to PDML output for a text only hf
    adds  74eace1   Announce messages should only have a TLV if the message length is > 64.


Summary of changes:
 epan/dissectors/packet-ptp.c |  354 ++++++++++++++++++++++--------------------
 1 file changed, 184 insertions(+), 170 deletions(-)