Wireshark-commits: [Wireshark-commits] master a71f680: Qt: Rework the "Manage Interfaces" dialog.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a71f6807b82bb4a4149141af7eff79738304ee22
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
a71f680 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Rework the "Manage Interfaces" dialog.
Convert QTableWidget to QTreeWidget.
It looks like the GTK+ version has a separate set of apply/save buttons
for each tab which *only* operates on that tab. This can result unexpected
behavior which throws away changes if the user updates more than one
tab. Use a single "OK" button that applies all of our changes instead.
Reorder the tabs. Put Local Interfaces first and select it by default.
Always show Remote Interfaces. Disable it on platforms that don't have
PCAP_REMOTE.
Automatically start editing when we add a new pipe. Don't immediately
update pipe interface settings. Wait until we hit "OK" instead.
Rename NewFileDelegate to PathChooserDelegate. Note that we might want
to move it use it elsewhere in the application.
Try switching the user-facing terminology from "Hide" to the more
positive "Show".
Tell the user that we don't save pipe or remote interface settings.
Add a help URL for the "Manage Interfaces" dialog box.
Use the GLib and Qt string functions and classes to split and join
comma-separated preferences. This makes sure capture_dev_user_descr_find
doesn't skip over the first interface. It also keeps the Qt code from
adding a leading comma to our capture preferences.
Add a note about strings to README.qt. Summary: Use QStrings.
For another day:
- If we *do* save remote settings we need to store credentials securely,
e.g. with CryptProtectData.
- Get rid of the remote settings dialogs. Their controls should fit in the
remote settings tab.
- Add an extcap tab.
- We need getter/setter functions for global_capture_opts.all_ifaces. We
iterate over it *way* too much.
Change-Id: Ib7b61972f3ece4325e0230f725e7f2678acbb24b
Reviewed-on: https://code.wireshark.org/review/3873
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from b65d0e0 set usb_dissector_table for control messages to "other" and "reserved" add a comment to explain this
adds a71f680 Qt: Rework the "Manage Interfaces" dialog.
Summary of changes:
doc/README.qt | 12 +-
ui/capture_ui_utils.c | 70 ++--
ui/help_url.c | 3 +
ui/help_url.h | 1 +
ui/qt/capture_interfaces_dialog.cpp | 84 ++--
ui/qt/capture_interfaces_dialog.ui | 4 +-
ui/qt/manage_interfaces_dialog.cpp | 580 ++++++++++++++++-----------
ui/qt/manage_interfaces_dialog.h | 74 ++--
ui/qt/manage_interfaces_dialog.ui | 738 ++++++++++++++---------------------
ui/qt/packet_list.h | 1 -
ui/qt/remote_capture_dialog.cpp | 2 +
ui/qt/remote_settings_dialog.cpp | 2 +
12 files changed, 753 insertions(+), 818 deletions(-)
