Wireshark-commits: [Wireshark-commits] master d04ec41: Use FreeRADIUS's warning pragma controls to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Aug 2014 21:17:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d04ec412d608deb4112d11f495f7efc3070348f7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d04ec41 by Guy Harris (guy@xxxxxxxxxxxx):

    Use FreeRADIUS's warning pragma controls to suppress Apple complaints.
    
    Apple would really rather that you use their Shiny Happy Frameworks
    rather than those crufty old cross-platform APIs.  We are a
    cross-platform program, and will use platform-specific APIs only if
    there's enough benefit to doing so - and, in this case, that means
    "using the platform-specific APIs on OS X and the other APIs on other
    platforms", so that's two code paths to maintain, so "enough benefit"
    has to outweigh the issues with that.
    
    Change-Id: I370ba469a6f5892143d72179d15c9fe22d664fdf
    Reviewed-on: https://code.wireshark.org/review/3881
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1b3bc9b   checkhf.pl: (Trivial) remove trailing whitespace.
    adds  d04ec41   Use FreeRADIUS's warning pragma controls to suppress Apple complaints.


Summary of changes:
 asn1/kerberos/packet-kerberos-template.c |    6 ++
 wsutil/Makefile.common                   |    1 +
 wsutil/ws_diag_control.h                 |   96 ++++++++++++++++++++++++++++++
 3 files changed, 103 insertions(+)
 create mode 100644 wsutil/ws_diag_control.h