Wireshark-commits: [Wireshark-commits] master 4014698: packet-erf: added dissector table for "erf.t
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=401469880b8b98a4d42011bdf9af7fbb67c6f057
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
4014698 by Wasim Abu Moch (wasim@xxxxxxxxxxxx):
packet-erf: added dissector table for "erf.types.type" type field.
1- removed unnecessary include <wiretap/erf.h>
2- used fall through in protocol switch case instead of calling same
function with same params.
fixes/changes after review with Evan Huus, changes ETH/IPv4/IPv6/Infiniband/InfinibandLink
to use dissector table instead of direct function calls.
other protocols should be called in the same way, we'll do it when have
the time.
instead of calling subdissector directly from packet-erf.c code it's
easier to declare this and each time we need to register a new
protocol over erf format we sould easily extend it from the protcol module
instead using "dissector_add_uint()" function.
the change is still backward compatible, if no upper protocol is
registered for the specifc type an old fasion direct function call
is performed.
Change-Id: I3ae1ccfdd49ab8f90667185296cc950dc2184475
Reviewed-on: https://code.wireshark.org/review/3670
Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from ca5fa53 Create an IE item for the "Apparent Address" IE.
adds 4014698 packet-erf: added dissector table for "erf.types.type" type field.
Summary of changes:
epan/dissectors/packet-erf.c | 63 ++++++-----------------------------
epan/dissectors/packet-eth.c | 2 ++
epan/dissectors/packet-infiniband.c | 10 +++++-
epan/dissectors/packet-ip.c | 2 ++
epan/dissectors/packet-ipv6.c | 2 ++
5 files changed, 26 insertions(+), 53 deletions(-)
