Wireshark-commits: [Wireshark-commits] master 0cda27c: "Highly discourage" use of proto_tree_add_te
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 19 Aug 2014 16:20:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0cda27c83e4aeadb195c9e9bbf55d51db5244347
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0cda27c by Michael Mann (mmann78@xxxxxxxxxxxx):

    "Highly discourage" use of proto_tree_add_text.
    
    Change-Id: I2e8d18df71688c654f7acaff51fae7823c08aa6a
    Reviewed-on: https://code.wireshark.org/review/3677
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  d7e4564   Use dissect_e212_imsi() to dissect IMSI fix offset in dissect_e212_mcc_mnc_in_address().
    adds  0cda27c   "Highly discourage" use of proto_tree_add_text.


Summary of changes:
 doc/README.dissector |   32 +++++++++++++++-----------------
 epan/proto.c         |    4 ++--
 epan/proto.h         |    4 ++--
 tools/checkAPIs.pl   |    4 +++-
 4 files changed, 22 insertions(+), 22 deletions(-)