Wireshark · Wireshark-commits: [Wireshark-commits] master 018b84d: Refactor "common" hostlist/endpoint table functionality.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=018b84de84343306f731ca04b3d20dd07064cdef
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

018b84d by Michael Mann (mmann78@xxxxxxxxxxxx):

    Refactor "common" hostlist/endpoint table functionality.
    
    This is very similar in architecture to the changes made to the Conversation table functionality.  Since all conversations have endpoints/hostlists, the "registered" list is shared for both.
    
    Change-Id: Ie8c6910a68a1b3f27c5b18c4494f49b9404a7b31
    Reviewed-on: https://code.wireshark.org/review/3214
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a76c888   Add missing field to the list of fields to register.
    adds  018b84d   Refactor "common" hostlist/endpoint table functionality.


Summary of changes:
 epan/conversation_table.c          |  246 ++++++++++++-
 epan/conversation_table.h          |  118 +++++--
 epan/dissectors/packet-eth.c       |   30 +-
 epan/dissectors/packet-fc.c        |   27 +-
 epan/dissectors/packet-fddi.c      |   27 +-
 epan/dissectors/packet-ieee80211.c |   26 +-
 epan/dissectors/packet-ip.c        |   26 +-
 epan/dissectors/packet-ipv6.c      |   30 +-
 epan/dissectors/packet-ipx.c       |   27 +-
 epan/dissectors/packet-jxta.c      |   26 +-
 epan/dissectors/packet-ncp.c       |   24 +-
 epan/dissectors/packet-rsvp.c      |   25 +-
 epan/dissectors/packet-sctp.c      |   24 +-
 epan/dissectors/packet-tcp.c       |   30 +-
 epan/dissectors/packet-tr.c        |   29 +-
 epan/dissectors/packet-udp.c       |   36 +-
 epan/dissectors/packet-usb.c       |   26 +-
 tfshark.c                          |    1 -
 tshark.c                           |    1 +
 ui/conversation_ui.h               |    2 +-
 ui/gtk/CMakeLists.txt              |   15 -
 ui/gtk/Makefile.common             |   15 -
 ui/gtk/conversations_table.h       |    2 +-
 ui/gtk/hostlist_eth.c              |   85 -----
 ui/gtk/hostlist_fc.c               |   85 -----
 ui/gtk/hostlist_fddi.c             |   84 -----
 ui/gtk/hostlist_ip.c               |   83 -----
 ui/gtk/hostlist_ipv6.c             |   88 -----
 ui/gtk/hostlist_ipx.c              |   84 -----
 ui/gtk/hostlist_jxta.c             |   81 -----
 ui/gtk/hostlist_ncp.c              |   82 -----
 ui/gtk/hostlist_rsvp.c             |   88 -----
 ui/gtk/hostlist_sctp.c             |   82 -----
 ui/gtk/hostlist_table.c            |  674 +++++++++++-------------------------
 ui/gtk/hostlist_table.h            |  104 ++----
 ui/gtk/hostlist_tcpip.c            |   84 -----
 ui/gtk/hostlist_tr.c               |   84 -----
 ui/gtk/hostlist_udpip.c            |   84 -----
 ui/gtk/hostlist_usb.c              |   81 -----
 ui/gtk/hostlist_wlan.c             |   82 -----
 ui/gtk/main.c                      |    2 +
 ui/gtk/main_menubar.c              |   96 +++--
 ui/qt/main.cpp                     |    1 +
 43 files changed, 1029 insertions(+), 1918 deletions(-)
 delete mode 100644 ui/gtk/hostlist_eth.c
 delete mode 100644 ui/gtk/hostlist_fc.c
 delete mode 100644 ui/gtk/hostlist_fddi.c
 delete mode 100644 ui/gtk/hostlist_ip.c
 delete mode 100644 ui/gtk/hostlist_ipv6.c
 delete mode 100644 ui/gtk/hostlist_ipx.c
 delete mode 100644 ui/gtk/hostlist_jxta.c
 delete mode 100644 ui/gtk/hostlist_ncp.c
 delete mode 100644 ui/gtk/hostlist_rsvp.c
 delete mode 100644 ui/gtk/hostlist_sctp.c
 delete mode 100644 ui/gtk/hostlist_tcpip.c
 delete mode 100644 ui/gtk/hostlist_tr.c
 delete mode 100644 ui/gtk/hostlist_udpip.c
 delete mode 100644 ui/gtk/hostlist_usb.c
 delete mode 100644 ui/gtk/hostlist_wlan.c